Add a workflow to open a PR to the next stage when the stage of an RFC has been updated #844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kategengler
force-pushed
the
kg-workflow-to-advance-rfcs
branch
from
24ee145 to
45e0054
Compare
This was referenced Aug 19, 2022
Closed
wagenet
approved these changes
Aug 23, 2022
|
I think it's fine. There are probably better ways to do some of it, but it works and should be relatively maintainable 🤞 |
|
Created user @emberjs-rfcs-bot for the token |
wagenet
approved these changes
Sep 1, 2022
has been updated - Fails if more than one RFC has been updated in a single push - Uses templates in .github/PULL_REQUEST_TEMPLATE for the body of the opened RFCs, with substitution of specific variables - Sets labels on the new PR - Updates the newly opened PR with a commit that adds the the link to the PR to the metadata
markdown. It renders line breaks that would otherwise be ignored. This removes all linebreaks of convenience from the templates so that they will render according to available width in the PR body
recommended Open advancement PRs as drafts
Enumerate teams in Ready for Release template along with github team names for ease of reference when assigning
`S-Proposed` Reconfigure GH actions to use composite actions and as multiple jobs so it is easy to see when they decide not to run based on the scenario
kategengler
force-pushed
the
kg-workflow-to-advance-rfcs
branch
from
21c0c27 to
be19c92
Compare
- Convert from deprecated set-ouput to Github's env files system - Document the workflows and actions and methods of testing - Add some additional outputs for easier debugging
wagenet
approved these changes
Nov 11, 2022
to the primary branch. Generate an artifact file of data when new PRs to advance are opened.
advance will open automatically
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO
emberjs/rfcs. Get a personal access token with scope 'repo' and add to the repo's secrets underPERSONAL_ACCESS_TOKEN. This is required so that the opened PRs will trigger the regular github actions.Advance RFC workflow
opened RFCs, with substitution of specific variables
the PR to the metadata
Example PRs
Newly opened RFC workflow
Example
Label New RFC workflow
S-Proposedlabel to newly opened PRs that add an RFCTriggering open advancement PR
This is a workflow triggered by workflow_dispatch, either manually or through the REST API. Given an input
rfc-pathit will determine the next stage, if any, from that RFC and open a PR to advance, if necessary. We can use this workflow + the REST API to open advancement PRs for existing RFCs that are incomplete. Before we start merging RFCs with stages, we can safely run this workflow for all existing RFCs to open the advancement PRs in bulk.